[C API] Additional API coverage: IndexLSH, I/O, meta-indexes #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make index downcast declaration+definition possible with macros - use macros on existing index types
- new header index_io_c.h for access to the index_io.h API - function`faiss_write_index` and overloads for dumping index to a file - function`faiss_read_index` and overloads for reading index from a file - function`faiss_clone_index` for cloning an index - update C example to save index to a file
|
This looks like a legitimate extension of the C api. Thanks! |
CaucherWang
pushed a commit
to CaucherWang/faiss-learned-termination
that referenced
this pull request
Sep 16, 2022
…kresearch#425) * [c_api] leverage index downcast - make index downcast declaration+definition possible with macros - use macros on existing index types * [c_api] Add IndexLSH to C API * [c_api] Add Index IO interface - new header index_io_c.h for access to the index_io.h API - function`faiss_write_index` and overloads for dumping index to a file - function`faiss_read_index` and overloads for reading index from a file - function`faiss_clone_index` for cloning an index - update C example to save index to a file * [c_api] Add IndexIDMap and IndexShards API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the C API with some some functions and types for accessing features in the library which may be useful in bindings. It is composed of 3 major contributions (feel free to let me know if you would like separate pull requests instead):
IndexLSHto the C interface, which to my understanding isn't accessible through the index factory.Although this is not yet fully tested, generating the low-level Rust bindings containing these changes was successful and did not interfere with the rest of the library (Travis build).