Skip to content

Conversation

piamo
Copy link
Contributor

@piamo piamo commented Apr 11, 2018

clear id_map after index reset

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@beauby
Copy link
Contributor

beauby commented Apr 11, 2018

Hi @Pigghost – thanks for the PR. Looks sensible to me. Thoughts @mdouze?

@beauby beauby requested a review from mdouze April 11, 2018 09:48
@mdouze
Copy link
Contributor

mdouze commented May 2, 2018

Hi
Thanks for the fix and sorry for the lag ;-)

@mdouze mdouze merged commit 5387697 into facebookresearch:master May 2, 2018
@piamo piamo deleted the update-idmap-reset branch May 2, 2018 11:47
CaucherWang pushed a commit to CaucherWang/faiss-learned-termination that referenced this pull request Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants