Add faiss.IO_FLAG_SKIP_IVFPQ_PRECOMPUTE_TABLE flag for faiss.read_index() #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D39747978 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D39747978 |
alexanderguzhva
added a commit
to alexanderguzhva/faiss
that referenced
this pull request
Sep 23, 2022
…acebookresearch#2489) Summary: Pull Request resolved: facebookresearch#2489 Currently, Faiss does not save the precomputed_table for IVFPQ when saving an index, and reconstructs one on the fly upon loading. The introduced flag allows to skip the reconstruction during faiss.read_index() Reviewed By: mdouze Differential Revision: D39747978 fbshipit-source-id: 3c10004989ff2792ccdc6ba23653da60361237ff
alexanderguzhva
force-pushed
the
export-D39747978
branch
from
7dec1ce to
c04dd46
Compare
…acebookresearch#2489) Summary: Pull Request resolved: facebookresearch#2489 Currently, Faiss does not save the precomputed_table for IVFPQ when saving an index, and reconstructs one on the fly upon loading. The introduced flag allows to skip the reconstruction during faiss.read_index() Reviewed By: mdouze Differential Revision: D39747978 fbshipit-source-id: 1e23883ae5c1ce4cdcb85c24922db4504af2758d
|
This pull request was exported from Phabricator. Differential Revision: D39747978 |
alexanderguzhva
force-pushed
the
export-D39747978
branch
from
c04dd46 to
d9fb23c
Compare
|
not save to disk, and not compute it when load ? why ? When to compute it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, Faiss does not save the precomputed_table for IVFPQ when saving an index, and reconstructs one on the fly upon loading. The introduced flag allows to skip the reconstruction during faiss.read_index()
Differential Revision: D39747978