Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile gcc 7.3.0 #1593

Closed
wants to merge 2 commits into from
Closed

Fix compile gcc 7.3.0 #1593

wants to merge 2 commits into from

Conversation

mdouze
Copy link
Contributor

@mdouze mdouze commented Dec 26, 2020

A small compilation issue with gcc 7.3.0, does not appear with 7.4.0.

Also updated the readme.

facebook-github-bot
facebook-github-bot reviewed Dec 26, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdouze has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mdouze
Copy link
Contributor Author

mdouze commented Dec 26, 2020

To check:


cmake=$(realpath ../faiss_20200817/current_cmake/bin/cmake)

$cmake -B build -DCMAKE_CXX_COMPILER=/private/home/matthijs/anaconda3/envs/faiss_latest_cmake/bin/x86_64-conda_cos6-linux-gnu-g++  -DFAISS_ENABLE_GPU=OFF -DBLA_VENDOR=Intel10_64_dyn -DMKL_LIBRARIES=/private/home/matthijs/anaconda3/envs/faiss_latest_cmake/lib -DPython_EXECUTABLE=$(which python ) -DFAISS_OPT_LEVEL=avx2


make -C build -j 10 VERBOSE=1

@facebook-github-bot
Copy link
Contributor

@mdouze merged this pull request in 05774f1.

@beauby beauby deleted the fix-compile-gcc-7.3.0 branch January 5, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdouze @facebook-github-bot