Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cast input argument #1175

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add cast input argument #1175

merged 1 commit into from
Apr 5, 2024

Conversation

whbldhwj
Copy link

@whbldhwj whbldhwj commented Apr 3, 2024 •
edited
Loading

What does this PR do?

Add cast_input to let users bypass the fp16 casting in FSDP.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2024
@whbldhwj whbldhwj requested a review from jiecaoyu April 3, 2024 23:00
@whbldhwj whbldhwj force-pushed the ngoyal_changes_for_pp_fp8_jiecaoyu_free_fp16_shard_cast_input branch from 739d7d3 to 1056da9 Compare April 3, 2024 23:52
@jiecaoyu jiecaoyu merged commit 7bcbc80 into ngoyal_changes_for_pp_fp8_jiecaoyu_free_fp16_shard Apr 5, 2024
1 of 18 checks passed
chrisxcai pushed a commit that referenced this pull request May 15, 2024
@whbldhwj @chrisxcai
Add cast input argument (#1175)
f039a3a 
Co-authored-by: Jie Wang <jiewang@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiecaoyu jiecaoyu jiecaoyu approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whbldhwj @jiecaoyu @facebook-github-bot