Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up locobot setup #345

Merged
merged 6 commits into from
Apr 23, 2021
Merged

Cleaning up locobot setup #345

merged 6 commits into from
Apr 23, 2021

Conversation

anuragprat1k
Copy link
Contributor

Description

Fixing a few things

  1. removed a circular dependency between locobot.agent.dance and locobot.agent.tasks by moving DanceMovement to objects.py.
  2. Adding specific versions of pytorch and cudatoolkit, and use of setup.py

deps

Fixes # (issue)

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.

@anuragprat1k anuragprat1k requested a review from soumith April 23, 2021 22:45
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2021
@anuragprat1k anuragprat1k merged commit 2635d74 into main Apr 23, 2021
@anuragprat1k anuragprat1k deleted the anurag/reqs branch April 23, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants