[Polymetis] Completely expose Franka Hand gripper API #1399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #1398 highlights an inflexibility of
franka::Gripper::move
, which is currently the only API Polymetis is using to command the Franka Hand.Basically the move command blocks until it reaches the desired goal, which causes problems during grasping.
This PR exposes
franka::Gripper::grasp
, which is a clunky API that at least allows the user to execute a grasp instead of commanding the gripper to 0 width.Type of change
Please check the options that are relevant.
Type of requested review
Before and After
If this PR introduces a change or fixes a bug, please add before and after screenshots (if this is causes a UX change) or before and after examples(this could be plain text, videos etc ) to demonstrate the change.
If this PR introduces a new feature, please also add examples or screenshots demonstrating the feature.
Testing
Tested on hardware
Checklist:
tests/scripts
, (2) asv benchmarks.