Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New End Effectors in MuJoCo #1359

Merged
merged 3 commits into from
Aug 25, 2022
Merged

New End Effectors in MuJoCo #1359

merged 3 commits into from
Aug 25, 2022

Conversation

laikhtewari
Copy link
Contributor

@laikhtewari laikhtewari commented Aug 25, 2022

Description

Robot models (URDF and MJCF) + configurations are created for franka with different end effectors (currently robotiq 85)

Fixes # (issue)

T123146522

Type of change

Please check the options that are relevant.

  • Bug fix (non-breaking change that fixes an issue)
  • Proposes a change (non-breaking change that isn't necessarily a bug)
  • Refactor
  • New feature (non-breaking change that adds a new functionality)
  • Breaking change (fix or feature that would break some existing functionality downstream)
  • This is a unit test
  • Documentation only change
  • Datasets Release
  • Models Release

Type of requested review

  • I want a thorough review of the implementation.
  • I want a high level review.
  • I want a deep design review.

Before and After

Screen Shot 2022-08-25 at 4 37 01 PM

Testing

DISPLAY=:100 launch_robot.py robot_client=franka_robotiq_85_mujoco_sim.yaml robot_model=franka_panda_robotiq_85

Checklist:

  • I have performed manual end-to-end testing of the feature in my environment.
  • I have added Docstrings and comments to the code.
  • I have made changes to existing documentation where needed.
  • I have added tests that show that the PR is functional.
  • New and existing unit tests pass locally with my changes.
  • I have added relevant collaborators to review the PR before merge.
  • [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2022
@1heart 1heart marked this pull request as ready for review August 25, 2022 19:17
Copy link
Contributor

@1heart 1heart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please symlink or otherwise more cleanly reference the existing mesh files. If possible, get rid of the empty space between the gripper and the arm. Otherwise, lgtm.

@codecov-commenter
Copy link

Codecov Report

Merging #1359 (c1fa706) into main (5e4d64d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   34.13%   34.13%           
=======================================
  Files         358      358           
  Lines       35541    35541           
=======================================
+ Hits        12131    12132    +1     
+ Misses      23410    23409    -1     
Impacted Files Coverage Δ
interpreter/robot/tests/world.py 75.18% <0.00%> (+0.72%) ⬆️

@laikhtewari laikhtewari merged commit 768b118 into main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants