-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HiTL Dashboard - Updated test to use s3 mock #1337
base: main
Are you sure you want to change the base?
Conversation
…ebookresearch/fairo into hitl_dashboard_refactor_test
dc9c977
to
b697ec8
Compare
0e5aed7
to
e0348ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ship it!
Hi @mialsy! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Description
Updated tests in HiTL Dashboard to use s3 mock rather than actually accessing s3 bucket.
Type of change
Please check the options that are relevant.
Type of requested review
Before and After
Before: use actual s3 client.
After: use mocked s3 client.
Testing
Run the test via:
Checklist:
tests/scripts
, (2) asv benchmarks.