Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

add full-model gradient clipping to optimizer #287

Merged
merged 1 commit into from
Nov 15, 2020
Merged

add full-model gradient clipping to optimizer #287

merged 1 commit into from
Nov 15, 2020

Conversation

ppwwyyxx
Copy link
Contributor

... so that the trainer doesn't depend on DefaultTrainer's internals.

Test plan:

Added a print statement before clipping, and run

python train_net.py --config configs/detr_256_6_6_torchvision.yaml --num-gpus 1 SOLVER.IMS_PER_BATCH 2

clipping is executed.

fix #282

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 14, 2020
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ppwwyyxx !

@fmassa fmassa merged commit a54b778 into facebookresearch:master Nov 15, 2020
facebook-github-bot pushed a commit to facebookresearch/detectron2 that referenced this pull request Nov 17, 2020
Summary:
Setting __class__ is a bit too magic.
Inspired by facebookresearch/detr#287

Reviewed By: theschnitz

Differential Revision: D24977034

fbshipit-source-id: de96db03e2635148b7ab81cec01130a05287f6ff
chromestone added a commit to umd-fire-coml/detr that referenced this pull request Jan 7, 2021
add full-model gradient clipping to optimizer (facebookresearch#287)
bjuncek pushed a commit to bjuncek/detr that referenced this pull request Apr 28, 2021
Copy link

@heryck237 heryck237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pot'´´tes swwwwwwwpwpwjggflptddy'hô
PSAllleledaddddsmsmfsgffz'’0 puggyrgygggggtrsErJGgnwelw
@@08@
9Iw'´
@@ cc lui cc gcvvbkkltdldtksmmt dccccvggcvvgccvvvgcccccccggcccccccccccg
Wr we
Oo
ooo oh. Ocreuse riollemmhl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[d2 wrapper error : AttributeError: 'Trainer' object has no attribute '_data_loader_iter']
4 participants