This repository was archived by the owner on Apr 28, 2023. It is now read-only.
emitHalideExpr: use isl AST expression generator to print expression #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skimo-openhub
force-pushed
the
pr/fix-200
branch
from
bf225f0 to
5859eab
Compare
ftynse
previously approved these changes
Mar 23, 2018
The printed expression is derived from plugging in the inverse schedule. This inverse schedule may have multiple disjuncts, especially if the original schedule tree has disjunctive filters, such as is the case in #200. The expression can therefore not be assumed to consist of a single disjunct. Use the AST expression generator instead of manually trying to pick the affine expression apart. Ideally, this should use the AST build at the point where the user statement was created, but this requires more invasive changes. Closes #200
ftynse
approved these changes
Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The printed expression is derived from plugging in the inverse schedule.
This inverse schedule may have multiple disjuncts, especially
if the original schedule tree has disjunctive filters, such as
is the case in #200.
The expression can therefore not be assumed to consist of
a single disjunct.
Use the AST expression generator instead of manually trying
to pick the affine expression apart.
Ideally, this should use the AST build at the point
where the user statement was created, but this requires
more invasive changes.
Closes #200