Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Adding computed phi to self in HNSW indexer #102

Merged

Conversation

martiansideofthemoon
Copy link
Contributor

@martiansideofthemoon martiansideofthemoon commented Feb 3, 2021

I get a RuntimeError in _index_batch() without this change, in this line: https://github.com/facebookresearch/DPR/blob/master/dpr/indexer/faiss_indexers.py#L166

@facebook-github-bot
Copy link

Hi @martiansideofthemoon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@vlad-karpukhin vlad-karpukhin merged commit 4216147 into facebookresearch:master Feb 3, 2021
@vlad-karpukhin
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants