Add clipping to sigmoid reciprocal method #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Added clipping to sigmoid reciprocal method that can be adjusted or turned off using MPCConfig's `sigmoid_tanh_clip_value` attribute. The purpose of this is to prevent very large inputs to significantly affect the output of the sigmoid. Differential Revision: D21870906 fbshipit-source-id: 43da9d990252d980a0d9045c2d93a9b62a208e04
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21870906 |
tanjuntao
pushed a commit
to tanjuntao/CrypTen
that referenced
this pull request
Nov 27, 2023
Summary: Pull Request resolved: fairinternal/CrypTen#130 running out mem for RTD if we pick up non CPU bits (Note: this ignores all push blocking failures!) Reviewed By: knottb, marksibrahim Differential Revision: D17842631 fbshipit-source-id: 334797680711ca5decbcb1fb5f9dfa96a2b44a42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added clipping to sigmoid reciprocal method that can be adjusted or turned off using MPCConfig's
sigmoid_tanh_clip_valueattribute.The purpose of this is to prevent very large inputs to significantly affect the output of the sigmoid.
Differential Revision: D21870906