Use floordiv in encoder (#209) #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: fairinternal/CrypTen#209 PyTorch is making the final switch to a truediv that will correspond to floating point division for LongTensors. This diff fixes instances in encoder.py that still used truediv where we need floordiv Differential Revision: D21839219 fbshipit-source-id: 61923c776dafeba8d3db7818281d719779c6c70b
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D21839219 |
|
This pull request has been merged in 4854e18. |
tanjuntao
pushed a commit
to tanjuntao/CrypTen
that referenced
this pull request
Nov 27, 2023
Summary: Pull Request resolved: fairinternal/CrypTen#129 Removed it entirely to check default behavior (Note: this ignores all push blocking failures!) Reviewed By: vshobha Differential Revision: D17841418 fbshipit-source-id: c1af41c608b527497e710420bbfbbe5b6a38baa7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request resolved: https://github.com/fairinternal/CrypTen/pull/209
PyTorch is making the final switch to a truediv that will correspond to floating point division for LongTensors.
This diff fixes instances in encoder.py that still used truediv where we need floordiv
Differential Revision: D21839219