This repository was archived by the owner on May 13, 2025. It is now read-only.
use set_() instead of setting .data directly #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
knottb
approved these changes
May 8, 2020
There was a problem hiding this comment.
@lvdmaaten has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
7 tasks
|
@lvdmaaten merged this pull request in 5970e4d. |
nairbv
reviewed
May 18, 2020
| result.share.data = getattr(beaver, op)( | ||
| result, y, *args, **kwargs | ||
| ).share.data | ||
| result.share.set_(getattr(beaver, op)( |
There was a problem hiding this comment.
I think the comment above is stale now.
Is the .data below still needed? I think in pytorch we intend to eventually deprecate .data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
There is an issue with setting a torch tensor using the
.dataattribute here and here, those lines are throwing anAttributeError: can't set attribute. My use-case uses PySyft which might be the cause of throwing that error but I believe that using.set_instead won't affect the current implementation. I got the fix from a related issue pytorch/pytorch#30987How Has This Been Tested (if it applies)
A complete training of the same model in Tutorial7.
Checklist