Disabled transitions if the transition duration is too short. #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixing a pattern of failures where ffmpeg fails when the transition duration is too short. Refactored the concatenation (no transition effect) in a separate function. Shifting to concatenation when the transition duration is below 0.5 seconds (chosen empirically). Differential Revision: D37737241 fbshipit-source-id: f0600fff0b0145e063eaf1c2afdaad2d74933b1e
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37737241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing a pattern of failures where ffmpeg fails when the transition duration is too short.
Refactored the concatenation (no transition effect) in a separate function. Shifting to concatenation when the transition duration is below 0.5 seconds (chosen empirically).
Differential Revision: D37737241