Extract fuzzer into expression/fuzzer directory #9651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
approved these changes
Apr 29, 2024
mbasmanova
added
the
ready-to-merge
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @rui-mo, could you rebase onto the latest main? There is a merge conflict in ExpressionFuzzerVerifier.h. Thanks! |
|
@kagamiori This PR was rebased. Thanks for the reminder. |
|
Hi @rui-mo, sorry that there is a new merge conflict again while I ran some tests. Could you rebase again? I'll try to land as soon as possible before the next merge conflict. |
|
@kagamiori This PR was rebased. Thanks for your help. |
|
@kagamiori merged this pull request in 3f3895d. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Extract fuzzer from expression/tests into expression/fuzzer directory. Pull Request resolved: facebookincubator#9651 Reviewed By: mbasmanova Differential Revision: D56710670 Pulled By: kagamiori fbshipit-source-id: aec746acfc8de97263fa840012ab1ea51b681ca7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract fuzzer from expression/tests into expression/fuzzer directory.