Support UNKNOWN type in Map function #9410
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55902535 |
✅ Deploy Preview for meta-velox canceled.
|
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Apr 9, 2024
Summary: Currently the key type of `MAP` is specified as `knownTypeVariable` which refuses to bind `UNKNOWN` type, while in Presto `MAP(UNKNOWN, UNKNOWN)` is valid. Differential Revision: D55902535
|
This pull request was exported from Phabricator. Differential Revision: D55902535 |
zacw7
added a commit
to zacw7/velox
that referenced
this pull request
Apr 9, 2024
Summary: Currently the key type of `MAP` is specified as `knownTypeVariable` which refuses to bind `UNKNOWN` type, while in Presto `MAP(UNKNOWN, UNKNOWN)` is valid. Differential Revision: D55902535
|
This pull request was exported from Phabricator. Differential Revision: D55902535 |
Summary: Currently the key type of `MAP` is specified as `knownTypeVariable` which refuses to bind `UNKNOWN` type, while in Presto `MAP(UNKNOWN, UNKNOWN)` is valid. Differential Revision: D55902535
|
This pull request was exported from Phabricator. Differential Revision: D55902535 |
kagamiori
approved these changes
Apr 9, 2024
|
This pull request has been merged in 89de5d3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
xiaoxmeng
pushed a commit
to xiaoxmeng/velox
that referenced
this pull request
Apr 10, 2024
Summary: Pull Request resolved: facebookincubator#9410 Currently the key type of `MAP` is specified as `knownTypeVariable` which refuses to bind `UNKNOWN` type, while in Presto `MAP(UNKNOWN, UNKNOWN)` is valid. Reviewed By: kagamiori Differential Revision: D55902535 fbshipit-source-id: 8c57736859d9f726b1cb7aa43cec74d60990c630
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9410 Currently the key type of `MAP` is specified as `knownTypeVariable` which refuses to bind `UNKNOWN` type, while in Presto `MAP(UNKNOWN, UNKNOWN)` is valid. Reviewed By: kagamiori Differential Revision: D55902535 fbshipit-source-id: 8c57736859d9f726b1cb7aa43cec74d60990c630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently the key type of
MAPis specified asknownTypeVariablewhich refuses to bindUNKNOWNtype, while in PrestoMAP(UNKNOWN, UNKNOWN)is valid.Differential Revision: D55902535