Disable approx_distinct result verifier in window fuzzer test #9407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…okincubator#9407) Summary: The approx_distinct result verifier for window fuzzer is giving false positive signals. It need to be fixed as described in facebookincubator#9347. Disable this result verifier until it is fixed. Differential Revision: D55879765
|
This pull request was exported from Phabricator. Differential Revision: D55879765 |
kagamiori
force-pushed
the
export-D55879765
branch
from
4401715
to
9da1e70
Compare
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D55879765 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
approved these changes
Apr 8, 2024
|
This pull request has been merged in fa177d3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…okincubator#9407) Summary: Pull Request resolved: facebookincubator#9407 The approx_distinct result verifier for window fuzzer is giving false positive signals. It need to be fixed as described in facebookincubator#9347. Disable this result verifier until it is fixed. Reviewed By: kgpai Differential Revision: D55879765 fbshipit-source-id: 23d3c30cc4660ccb111ef641ed22ef111f79e6a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The approx_distinct result verifier for window fuzzer is giving false positive signals. It need to be fixed as described in #9347. Disable this result verifier until it is fixed.
Differential Revision: D55879765