Throw kFileNotFound in all storage adapters #8662
Conversation
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@majetideepak and @mbasmanova , could you please help to review this PR? This PR is the follow up of #8615 to make sure all remote storage adapters have same error interface for file not found error. |
There was a problem hiding this comment.
@zhli1142015 Can we retain the existing checks for the error message?
Adding a new check for the error code should suffice.
mbasmanova
changed the title
| @@ -81,6 +81,7 @@ Storage Adapters | |||
| ~~~~~~~~~~~~~~~~ | |||
| Hive Connector allows reading and writing files from a variety of distributed storage systems. | |||
| The supported storage API are S3, HDFS, GCS, Linux FS. | |||
| If file is not found when reading, `openFileForRead` API throws `VeloxRuntimeError` with `error_code::kFileNotFound`. | |||
There was a problem hiding this comment.
Let's clarify that this behavior is necessary to support xxx configuration property.
There was a problem hiding this comment.
Updated, thanks.
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Got a linter warning: 
CC: @majetideepak |
|
@mbasmanova merged this pull request in 3c5d864. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Pull Request resolved: facebookincubator#8662 Reviewed By: pedroerp Differential Revision: D53416855 Pulled By: mbasmanova fbshipit-source-id: 7f0b7e475d7725ae98ce0a6ca6eb03130bbbea57
No description provided.