Add presto function 'to_base32' #8652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
This was referenced Feb 2, 2024
Joe-Abraham
force-pushed
the
to_base32
branch
from
c6f4282
to
d976584
Compare
karteekmurthys
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
@Joe-Abraham Thanks for splitting PRs. Please also add Presto e2e tests for these functions here: https://github.com/prestodb/presto/blob/master/presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeGeneralQueries.java
|
@karteekmurthys e2e test cases were added prestodb/presto#21537. Waiting for the velox changes to be merged and pulled to presto. |
6 tasks
Joe-Abraham
force-pushed
the
to_base32
branch
3 times, most recently
from
1be1df0
to
d5c5439
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
2 times, most recently
from
f39d90e
to
57c0d45
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
2 times, most recently
from
e3f2488
to
6d23b3b
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
3 times, most recently
from
d6fc45e
to
dec1883
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
5 times, most recently
from
0349258
to
32d15d5
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
from
32d15d5
to
c6461d7
Compare
Joe-Abraham
force-pushed
the
to_base32
branch
from
c6461d7
to
80e53ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add presto function 'to_base32'