Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor presto function base64 to make use of the new utility file #8651

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Feb 2, 2024

Refactor presto function base64 to make use of the new utility file

Dependencies

  1. Create utility file for encoding #8650
  2. Fix from_base64 Presto function for inputs without padding #8647

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit c01a22e
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67109aedf4df890008b66af1

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2024
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

velox/common/encode/Base64.cpp Outdated Show resolved Hide resolved
velox/common/encode/Base64.cpp Outdated Show resolved Hide resolved
velox/common/encode/CMakeLists.txt Outdated Show resolved Hide resolved
velox/common/encode/tests/CMakeLists.txt Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/EncoderUtils.h Outdated Show resolved Hide resolved
velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
Copy link

stale bot commented Aug 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the PR, make sure you've addressed reviewer comments, and rebase on the latest main. Thank you for your contributions!

Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I saw a few things missed earlier.
Once complete we can mark as for review and get additional feedback.

velox/common/encode/tests/Base64Test.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/EncoderUtilsTests.cpp Outdated Show resolved Hide resolved
velox/common/encode/tests/EncoderUtilsTests.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants