Add metric to cacth the double free error in mmap allocator #8648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bikramSingh91
approved these changes
Feb 8, 2024
xiaoxmeng
force-pushed
the
fatal
branch
2 times, most recently
from
eaf3afe
to
0187320
Compare
xiaoxmeng
changed the title
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
velox/common/base/Counters.cpp
Outdated
| @@ -143,6 +143,10 @@ void registerVeloxMetrics() { | |||
| DEFINE_METRIC( | |||
| kMetricMemoryPoolReservationLeakBytes, facebook::velox::StatType::SUM); | |||
|
|
|||
| // Tracks the count of double frees in memory allocator. | |||
There was a problem hiding this comment.
nit: how about: Tracks the count of double frees in memory allocator, indicating the possibility of buffer ownership issues when a buffer is freed more than once.
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…incubator#8648) Summary: Currently we only have a warning log for double free in mmap allocator and we shall also add a metric for production alert. Reviewed By: bikramSingh91 Differential Revision: D53341067 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D53341067 |
|
@xiaoxmeng merged this pull request in c4cd265. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
yanngyoung
pushed a commit
to yanngyoung/velox
that referenced
this pull request
Apr 12, 2024
…incubator#8648) Summary: Currently we only have a warning log for double free in mmap allocator and we shall also add a metric for production alert. Pull Request resolved: facebookincubator#8648 Reviewed By: bikramSingh91 Differential Revision: D53341067 Pulled By: xiaoxmeng fbshipit-source-id: 3d0979a1621ebae1180b3d59cd98345fd0c4dff8
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…incubator#8648) Summary: Currently we only have a warning log for double free in mmap allocator and we shall also add a metric for production alert. Pull Request resolved: facebookincubator#8648 Reviewed By: bikramSingh91 Differential Revision: D53341067 Pulled By: xiaoxmeng fbshipit-source-id: 3d0979a1621ebae1180b3d59cd98345fd0c4dff8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only have a warning log for double free in mmap allocator
and we shall also add a metric for production alert.