Disable pyvelox wheels build in macos temporarily. #8636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I am investigating in #8627 after removing the fbthrift build a ccache error surfaces which I haven't had the time to check yet. So disabeling it makes sense. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 12, 2024
…#8636) Summary: We are seeing pyvelox wheel builds fail on MacOS ( see issue [8635](facebookincubator#8635) ). This PR disables these builds while we investigate a fix. Pull Request resolved: facebookincubator#8636 Reviewed By: kevinwilfong Differential Revision: D53323448 Pulled By: kgpai fbshipit-source-id: d698947a64842cecef39e4b95112f228a06fdbf1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing pyvelox wheel builds fail on MacOS ( see issue 8635 ). This PR disables these builds while we investigate a fix.