Use Config::get(name, defaultValue) in HiveConfig

[zhli1142015]

No description provided.

[netlify]

✅ Deploy Preview for meta-velox ready!

Name	Link
🔨 Latest commit	8b30ae0
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/65bc6f6478dcdc0008960ed7
😎 Deploy Preview	https://deploy-preview-8633--meta-velox.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mbasmanova]

Thanks.

@kewang1024 Ke, would you help merge this PR?

[facebook-github-bot]

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[kewang1024]

Thanks for the refactor, LGTM

[kewang1024]

@zhli1142015 hey, can you help make sure the tests are all green? thanks!

[zhli1142015]

@zhli1142015 hey, can you help make sure the tests are all green? thanks!

I think the first time failure is not related to this change. now CI passed excet the pyvelox one.

seed: 
I20240201 23:04:57.298225 247272 JoinFuzzer.cpp:847] Testing plan #6
I20240201 23:04:57.298281 247272 JoinFuzzer.cpp:290] Executing query plan: 
-- HashJoin[RIGHT SEMI (PROJECT) u0=t0 AND u1=t1] -> t0:TINYINT, match:BOOLEAN
  -- TableScan[table: hive_table] -> u0:TINYINT, u1:VARCHAR
  -- TableScan[table: hive_table] -> t0:TINYINT, t1:VARCHAR
I20240201 23:04:57.314581 300435 Task.cpp:1085] All drivers (4) finished for task test_cursor 9715 after running for 15 ms.
I20240201 23:04:57.314648 300435 Task.cpp:1769] Terminating task test_cursor 9715 with state Finished after running for 15 ms.
I20240201 23:04:57.315595 247272 JoinFuzzer.cpp:312] Results: [ROW ROW<t0:TINYINT,match:BOOLEAN>: 500 elements, no nulls]
/root/project/velox/exec/tests/utils/QueryAssertions.cpp:1129: Failure
Failed
Expected 500, got 500
32 extra rows, 32 missing rows
10 of extra rows:
        5 | false
        10 | false
        22 | false
        38 | false
        39 | false
        51 | false
        56 | false
        56 | false
        56 | false
        56 | false

10 of missing rows:
        5 | true
        10 | true
        22 | true
        38 | true
        39 | true
        51 | true
        56 | true
        56 | true
        56 | true
        56 | true

[facebook-github-bot]

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@kewang1024 merged this pull request in 6a8f16f.

[conbench-facebook]

Conbench analyzed the 1 benchmark run on commit 6a8f16f3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.