Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install dependencies needed to support Azure Storage ABFS Connector #6418

Closed

Conversation

gaoyangxiaozhu
Copy link
Contributor

@gaoyangxiaozhu gaoyangxiaozhu commented Sep 5, 2023

install dependencies needed to support Azure Storage ABFS Connector, This update is one of the modifications necessary for issue #6415

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 2e7fca5
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/64faf8f66efe7e0008d140be

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 5, 2023
@gaoyangxiaozhu
Copy link
Contributor Author

can anyone help review ?

@pedroerp
Copy link
Contributor

@kgpai @assignUser could you guys help review this PR?

Copy link
Collaborator

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, I will add it to the conda env too (not merged yet)

@gaoyangxiaozhu
Copy link
Contributor Author

Looks fine to me, I will add it to the conda env too (not merged yet)

hey @assignUser thank you for approved. Would i know when this part change can be merged ? then I can do submit the following ABFS Read/Write PR both the PRe depends on this PR.

@facebook-github-bot
Copy link
Contributor

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gaoyangxiaozhu
Copy link
Contributor Author

@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hey @kgpai can i know when this change will be merged ?

@facebook-github-bot
Copy link
Contributor

@kgpai merged this pull request in e469799.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit e4697992.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

codyschierbeck pushed a commit to codyschierbeck/velox that referenced this pull request Sep 27, 2023
…acebookincubator#6418)

Summary:
install dependencies needed to support Azure Storage ABFS Connector, This update is one of the modifications necessary for issue facebookincubator#6415

Pull Request resolved: facebookincubator#6418

Reviewed By: pedroerp

Differential Revision: D49393106

Pulled By: kgpai

fbshipit-source-id: 3bf3739b50b35d0560ef7446a5530a11474dc072
codyschierbeck pushed a commit to codyschierbeck/velox that referenced this pull request Sep 27, 2023
…acebookincubator#6418)

Summary:
install dependencies needed to support Azure Storage ABFS Connector, This update is one of the modifications necessary for issue facebookincubator#6415

Pull Request resolved: facebookincubator#6418

Reviewed By: pedroerp

Differential Revision: D49393106

Pulled By: kgpai

fbshipit-source-id: 3bf3739b50b35d0560ef7446a5530a11474dc072
codyschierbeck pushed a commit to codyschierbeck/velox that referenced this pull request Sep 27, 2023
…acebookincubator#6418)

Summary:
install dependencies needed to support Azure Storage ABFS Connector, This update is one of the modifications necessary for issue facebookincubator#6415

Pull Request resolved: facebookincubator#6418

Reviewed By: pedroerp

Differential Revision: D49393106

Pulled By: kgpai

fbshipit-source-id: 3bf3739b50b35d0560ef7446a5530a11474dc072
ericyuliu pushed a commit to ericyuliu/velox that referenced this pull request Oct 12, 2023
…acebookincubator#6418)

Summary:
install dependencies needed to support Azure Storage ABFS Connector, This update is one of the modifications necessary for issue facebookincubator#6415

Pull Request resolved: facebookincubator#6418

Reviewed By: pedroerp

Differential Revision: D49393106

Pulled By: kgpai

fbshipit-source-id: 3bf3739b50b35d0560ef7446a5530a11474dc072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants