Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable push-down for decimal type #11298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable push-down for decimal type #11298

wants to merge 1 commit into from

Conversation

NEUpanning
Copy link
Contributor

@NEUpanning NEUpanning commented Oct 18, 2024 •
edited
Loading

Currently, int64_t enables push-down for decimal type. This PR disables push-down for decimal type regardless of c++ type.

Fixes #11290

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 18, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 18, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 06cb7d8
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6712078f46c1570008d0c2c2

@NEUpanning
Copy link
Contributor Author

@Yuhta Could you please help to review this PR? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectiveDecimalColumnReader::scanSpec_::valueHook_ may not be nullptr
2 participants
@NEUpanning @facebook-github-bot