Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Presto's to_iso8601 UDF uses JODA's default ISODateTimeFormat.dateTime()
formatter which uses the string 'Z' in place of the time zone offset if the time zone is
UTC.
https://www.joda.org/joda-time/apidocs/org/joda/time/format/ISODateTimeFormat.html#dateTime--
Internally JODA's DateTimeFormatter does this by taking an optional hard coded
string to use for the time zone offset if it's zero. I added something similar to Velox's
DateTimeFormatter.format and setting it in the to_iso8601 implementation.
I checked and other Presto UDFs that format TimestampWithTimeZones as strings,
e.g. format_datetime, do not use this option, so they do not need to be updated.
Differential Revision: D64488962