Add tests for Presto's map_subset UDF with TimestampWithTimezones #11242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 11, 2024 13:50
…nt_at UDF (facebookincubator#11239) Summary: Update SubscriptUtil to work with types that provide custom comparison. We can reuse the implementation for complex types, since that just uses the compare function provided by the Vector. With facebookincubator#11022 this just invokes the Type's custom implementation. Since they share the same underlying code this makes both map subscript and the element_at UDF work with custom comparison. Reviewed By: xiaoxmeng Differential Revision: D64256363
Summary: Presto's map_subset implementation for Generic types uses the hash and equals functions implemented for GenericViews. For TimestampWithTImeZone this recursively calls these functions on the CustomTypeWithCustomComparisonView the GenericView wraps, which supports custom comparison operators. So this UDF works as is with the recent changes earlier in this stack. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D64262952
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64262952 |
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
approved these changes
Oct 11, 2024
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Oct 11, 2024
…cebookincubator#11242) Summary: Presto's map_subset implementation for Generic types uses the hash and equals functions implemented for GenericViews. For TimestampWithTImeZone this recursively calls these functions on the CustomTypeWithCustomComparisonView the GenericView wraps, which supports custom comparison operators. So this UDF works as is with the recent changes earlier in this stack. Adding unit tests to verify this and ensure it doesn't break in the future. Reviewed By: xiaoxmeng Differential Revision: D64262952
|
This pull request has been merged in adbebfd. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Presto's map_subset implementation for Generic types uses the hash and equals
functions implemented for GenericViews. For TimestampWithTImeZone this
recursively calls these functions on the CustomTypeWithCustomComparisonView the
GenericView wraps, which supports custom comparison operators. So this UDF works
as is with the recent changes earlier in this stack.
Adding unit tests to verify this and ensure it doesn't break in the future.
Differential Revision: D64262952