Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded special treatment for $path and $bucket #11221

Closed
wants to merge 1 commit into from
Closed

Remove hard-coded special treatment for $path and $bucket #11221

wants to merge 1 commit into from
+32 −36

Commits on Oct 10, 2024

  1. Remove hard-coded special treatment for $path and $bucket (facebookin… 

    …cubator#11221)

Summary:

These special columns are engine-specific and should be handled during engine split generation by setting the corresponding values in split `infoColumns`.  For example in Prestissimo this is done in https://github.com/prestodb/presto/blob/48f0a0c1d380b1155dfd7c99b134a350627c7260/presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp#L1112-L1120.

Reviewed By: xiaoxmeng

Differential Revision: D64180231
    @Yuhta @facebook-github-bot
    Yuhta authored and facebook-github-bot committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    48fe9a9 View commit details
    Browse the repository at this point in the history