Memory arbitration related code refactor #11168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63815963 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Oct 4, 2024
Summary: Update participant operator methods to better support global arbitration. Remove stats from existing arbitrator stats which are not used much in production monitoring to simplify code Add memory arbitration context type to differentiate local arbitration context and global arbitration context. The latter doesn't have an associated request memory poll as in global arbitration optimization Rename ScopedMemoryPoolArbitrationContext to MemoryPoolArbitrationSection as we have too many context things in memory code space Add metrics used by global arbitration optimization and remove the ones not used much in production monitoring Differential Revision: D63815963
xiaoxmeng
force-pushed
the
export-D63815963
branch
from
2e7f6da
to
c7630fd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63815963 |
tanjialiang
approved these changes
Oct 4, 2024
Summary: Update participant operator methods to better support global arbitration. Remove stats from existing arbitrator stats which are not used much in production monitoring to simplify code Add memory arbitration context type to differentiate local arbitration context and global arbitration context. The latter doesn't have an associated request memory poll as in global arbitration optimization Rename ScopedMemoryPoolArbitrationContext to MemoryPoolArbitrationSection as we have too many context things in memory code space Add metrics used by global arbitration optimization and remove the ones not used much in production monitoring Reviewed By: tanjialiang Differential Revision: D63815963
xiaoxmeng
force-pushed
the
export-D63815963
branch
from
c7630fd
to
136e3a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63815963 |
|
This pull request has been merged in 7b6ef14. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
tanjialiang
reviewed
Oct 4, 2024
| // The time that waits for global arbitration queue. | ||
| uint64_t globalArbitrationWaitTimeUs_{0}; | ||
| // The time that starts global arbitration wait | ||
| uint64_t globalArbitrationStartTimeMs_{}; |
| slowCapacityGrowRatio, | ||
| minFreeCapacity, | ||
| succinctBytes(minFreeCapacity), |
There was a problem hiding this comment.
Can we add memoryPool back to prefix? It will help with readability. Also could you please make sure to make followup changes to all the same meaning name across the codebase to make it consistent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update participant operator methods to better support global arbitration.
Remove stats from existing arbitrator stats which are not used much in production monitoring to simplify code
Add memory arbitration context type to differentiate local arbitration context and global arbitration context. The latter
doesn't have an associated request memory poll as in global arbitration optimization
Rename ScopedMemoryPoolArbitrationContext to MemoryPoolArbitrationSection as we have too many context things
in memory code space
Add metrics used by global arbitration optimization and remove the ones not used much in production monitoring
Differential Revision: D63815963