Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base64 as a non-throwing API #11149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Oct 2, 2024

Follow-up PR: #10371

The following changes are done in this PR.

  1. Variable names are updated for better readability.
  2. Function declarations in Base64.h for better maintainability.
  3. Refactor the APIs in Base64 as non-throwing APIs.

Changing the char to std::string_view and std::string will be done in subsequent PR.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 4b0ca32
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66fe7a6acee7220008a584ea

@Joe-Abraham
Copy link
Contributor Author

@majetideepak Can you please review the changes?

@kgpai
Copy link
Contributor

kgpai commented Oct 11, 2024

Thanks @Joe-Abraham , based on brief glance, it seems its mostly renaming variables etc for readability and consistency (which is welcome change); Want to make sure I am not missing any material change.

@Joe-Abraham
Copy link
Contributor Author

@kgpai I have also made the APIs used in BinaryFunctions.h as non-throwing.

@majetideepak
Copy link
Collaborator

  1. Refactor the APIs in Base64 as non-throwing APIs.

@Joe-Abraham this should be its own PR since its a functional change. We can leave the remaining code improvements this PR.
Can you please open another PR with only the non-throwing API changes? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants