Use BufferPtr for HashProbe::outputTableRows_ #10864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D61875530 |
xiaoxmeng
approved these changes
Aug 27, 2024
velox/exec/HashProbe.cpp
Outdated
| for (auto i = 0; i < size; ++i) { | ||
| if (nullAware_) { | ||
| // Null-aware join may produce TRUE, FALSE or NULL. | ||
| if (filter_) { | ||
| if (leftSemiProjectIsNull_.isValid(i)) { | ||
| flatMatch->setNull(i, true); | ||
| } else { | ||
| bool hasMatch = outputTableRows_[i] != nullptr; | ||
| bool hasMatch = outputTableRows[i] != nullptr; |
There was a problem hiding this comment.
nit: NYC: const bool hasMatch
dittos? Thanks!
|
This pull request was exported from Phabricator. Differential Revision: D61875530 |
Yuhta
added a commit
to Yuhta/velox
that referenced
this pull request
Aug 28, 2024
Summary: Pull Request resolved: facebookincubator#10864 Follow up on facebookincubator#10832 (comment). Use `BufferPtr` so that the memory is counted in operator memory pool. Reviewed By: xiaoxmeng Differential Revision: D61875530
Yuhta
force-pushed
the
export-D61875530
branch
from
f4f64af
to
a173cf8
Compare
Summary: Pull Request resolved: facebookincubator#10864 Follow up on facebookincubator#10832 (comment). Use `BufferPtr` so that the memory is counted in operator memory pool. Reviewed By: xiaoxmeng Differential Revision: D61875530
Yuhta
force-pushed
the
export-D61875530
branch
from
a173cf8
to
2e34f19
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61875530 |
|
This pull request has been merged in 3d294e3. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 2, 2024
Summary: Pull Request resolved: facebookincubator#10864 Follow up on facebookincubator#10832 (comment). Use `BufferPtr` so that the memory is counted in operator memory pool. Reviewed By: xiaoxmeng Differential Revision: D61875530 fbshipit-source-id: ed51b6c4a2579d91f2821b45273851c08169bb7c
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebookincubator#10864 Follow up on facebookincubator#10832 (comment). Use `BufferPtr` so that the memory is counted in operator memory pool. Reviewed By: xiaoxmeng Differential Revision: D61875530 fbshipit-source-id: ed51b6c4a2579d91f2821b45273851c08169bb7c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follow up on
#10832 (comment).
Use
BufferPtrso that the memory is counted in operator memory pool.Differential Revision: D61875530