Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: TaskTest.taskReclaimStats #9301

Closed
kgpai opened this issue Mar 29, 2024 · 0 comments
Closed

Flaky Test: TaskTest.taskReclaimStats #9301

kgpai opened this issue Mar 29, 2024 · 0 comments
Labels
bug Something isn't working flaky-test triage Newly created issue that needs attention.

Comments

@kgpai
Copy link
Contributor

kgpai commented Mar 29, 2024

Bug description

taskReclaimStats seems to be failing intermittently.
See a recent runs : https://github.com/facebookincubator/velox/actions/runs/8474869421/job/23222019759

System information

N/A

Relevant logs

[ RUN      ] TaskTest.taskReclaimStats
E20240328 23:42:58.707890 55265 Exceptions.h:69] Line: ../../velox/exec/Task.cpp:1822, Function:terminate, Expression:  Aborted for external error, Source: RUNTIME, ErrorCode: INVALID_STATE
../../velox/exec/tests/TaskTest.cpp:1672: Failure
Expected equality of these values:
  taskStats.pipelineStats[0].driverStats.size()
    Which is: 0
  1
@kgpai kgpai added bug Something isn't working triage Newly created issue that needs attention. flaky-test labels Mar 29, 2024
@kgpai kgpai mentioned this issue Apr 1, 2024
Closed
@Yuhta Yuhta mentioned this issue Apr 1, 2024
Closed
Yuhta added a commit to Yuhta/velox that referenced this issue Apr 1, 2024
@Yuhta @facebook-github-bot
Update driver and operator stats when close by task
c152a8e 
Summary:
Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Differential Revision: D55601334
Yuhta added a commit to Yuhta/velox that referenced this issue Apr 1, 2024
@Yuhta @facebook-github-bot
Update driver and operator stats when close by task (facebookincubato…
75ab319 
…r#9327)

Summary:

Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Differential Revision: D55601334
Yuhta added a commit to Yuhta/velox that referenced this issue Apr 1, 2024
@Yuhta @facebook-github-bot
Update driver and operator stats when close by task (facebookincubato…
be1df5c 
…r#9327)

Summary:

Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Reviewed By: xiaoxmeng

Differential Revision: D55601334
Yuhta added a commit to Yuhta/velox that referenced this issue Apr 1, 2024
@Yuhta @facebook-github-bot
Update driver and operator stats when close by task (facebookincubato…
ebc3696 
…r#9327)

Summary:

Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Reviewed By: xiaoxmeng

Differential Revision: D55601334
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this issue Apr 4, 2024
@Yuhta @Joe-Abraham
Update driver and operator stats when close by task (facebookincubato…
d3c92cc 
…r#9327)

Summary:
Pull Request resolved: facebookincubator#9327

Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Reviewed By: xiaoxmeng

Differential Revision: D55601334

fbshipit-source-id: 501fc1493e966fccbeb1d1a41e52b5cab635a06f
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this issue Jun 7, 2024
@Yuhta @Joe-Abraham
Update driver and operator stats when close by task (facebookincubato…
ee37d09 
…r#9327)

Summary:
Pull Request resolved: facebookincubator#9327

Currently the stats are not updated if close is issued by task.

Fix facebookincubator#9301

Reviewed By: xiaoxmeng

Differential Revision: D55601334

fbshipit-source-id: 501fc1493e966fccbeb1d1a41e52b5cab635a06f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky-test triage Newly created issue that needs attention.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update driver and operator stats when close by task Yuhta/velox
1 participant
@kgpai