Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: ChecksumAggregateTest.reals #9292

Closed
mbasmanova opened this issue Mar 28, 2024 · 2 comments
Closed

Flaky test: ChecksumAggregateTest.reals #9292

mbasmanova opened this issue Mar 28, 2024 · 2 comments
Assignees
@xiaoxmeng
Labels
bug Something isn't working flaky-test triage Newly created issue that needs attention.

Comments

@mbasmanova
Copy link
Contributor

mbasmanova commented Mar 28, 2024 •
edited
Loading

Bug description

https://github.com/facebookincubator/velox/actions/runs/8471059992/job/23210217320?pr=9291

[ RUN      ] ChecksumAggregateTest.reals
../../velox/functions/lib/aggregates/tests/utils/AggregationTestBase.cpp:807: Failure
Expected equality of these values:
  0
  spilledBytes(*task)
    Which is: 144
Google Test trace:
../../velox/functions/lib/aggregates/tests/utils/AggregationTestBase.cpp:766: Run partial + final with spilling
../../velox/functions/lib/aggregates/tests/utils/AggregationTestBase.cpp:108: VALUES ('AAAAAAAAAAA='),('bAFBcIKzvC4=')
[  FAILED  ] ChecksumAggregateTest.reals (524 ms)

CC: @xiaoxmeng

System information

n/a

Relevant logs

No response
@mbasmanova mbasmanova added bug Something isn't working triage Newly created issue that needs attention. flaky-test labels Mar 28, 2024
@xiaoxmeng xiaoxmeng mentioned this issue Apr 10, 2024
Closed
@xiaoxmeng
Copy link
Contributor

Can't reproduce this offline so adding more log to help analyze in next occurrence: #9434

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this issue Apr 10, 2024
@xiaoxmeng
Add more debug info for flaky aggregation spill stats check
1fc00f6 
Aggregation test is flaky on circle ci which has seen unexpected spill stats with zero partial
input rows: facebookincubator#9292
Since we can reproduce this offline, add one more log to print out the number of input rows
for final aggregation. If there is non-zero final aggregation input rows, then we need to look
into if task stats collection is not reliable. Eventually, we shall check spill stats based on whether
spill injections have been triggered or not which is more reliable. But let's first figure out if
anything else in the test is wrong first.
facebook-github-bot pushed a commit that referenced this issue Apr 10, 2024
@xiaoxmeng @facebook-github-bot
Add more debug info for flaky aggregation spill stats check (#9434)
a3b4849 
Summary:
Aggregation test is flaky on circle ci which has seen unexpected spill stats with zero partial
input rows: #9292
Since we can't reproduce this offline, add one more log to print out the number of input rows
for final aggregation. If there is non-zero final aggregation input rows, then we need to look
into if task stats collection is not reliable. Eventually, we shall check spill stats based on whether
spill injections have been triggered or not which is more reliable. But let's first figure out if
anything else in the test is wrong first.

Pull Request resolved: #9434

Reviewed By: mbasmanova

Differential Revision: D55987679

Pulled By: xiaoxmeng

fbshipit-source-id: 8789f077adc877d1762f20b391c77ab87f4e6a61
yanngyoung pushed a commit to yanngyoung/velox that referenced this issue Apr 12, 2024
@xiaoxmeng @yanngyoung
Add more debug info for flaky aggregation spill stats check (facebook…
3088766 
…incubator#9434)

Summary:
Aggregation test is flaky on circle ci which has seen unexpected spill stats with zero partial
input rows: facebookincubator#9292
Since we can't reproduce this offline, add one more log to print out the number of input rows
for final aggregation. If there is non-zero final aggregation input rows, then we need to look
into if task stats collection is not reliable. Eventually, we shall check spill stats based on whether
spill injections have been triggered or not which is more reliable. But let's first figure out if
anything else in the test is wrong first.

Pull Request resolved: facebookincubator#9434

Reviewed By: mbasmanova

Differential Revision: D55987679

Pulled By: xiaoxmeng

fbshipit-source-id: 8789f077adc877d1762f20b391c77ab87f4e6a61
@xiaoxmeng
Copy link
Contributor

This should have been fixed by #9459

Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this issue Jun 7, 2024
@xiaoxmeng @Joe-Abraham
Add more debug info for flaky aggregation spill stats check (facebook…
0f7ece6 
…incubator#9434)

Summary:
Aggregation test is flaky on circle ci which has seen unexpected spill stats with zero partial
input rows: facebookincubator#9292
Since we can't reproduce this offline, add one more log to print out the number of input rows
for final aggregation. If there is non-zero final aggregation input rows, then we need to look
into if task stats collection is not reliable. Eventually, we shall check spill stats based on whether
spill injections have been triggered or not which is more reliable. But let's first figure out if
anything else in the test is wrong first.

Pull Request resolved: facebookincubator#9434

Reviewed By: mbasmanova

Differential Revision: D55987679

Pulled By: xiaoxmeng

fbshipit-source-id: 8789f077adc877d1762f20b391c77ab87f4e6a61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaoxmeng xiaoxmeng

Labels
bug Something isn't working flaky-test triage Newly created issue that needs attention.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbasmanova @xiaoxmeng