Skip to content

Commit

Permalink
Fix rebase error
Browse files Browse the repository at this point in the history
  • Loading branch information
liujiayi771 committed Sep 27, 2024
1 parent d6f02db commit 69a29bb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions velox/exec/HashBuild.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -407,12 +407,12 @@ void HashBuild::addInput(RowVectorPtr input) {
*lookup_,
input,
activeRows_,
false,
BaseHashTable::kNoSpillInputStartPartitionBit);
if (lookup_->rows.empty()) {
return;
}
table_->groupProbe(*lookup_);
table_->groupProbe(
*lookup_, BaseHashTable::kNoSpillInputStartPartitionBit);
return;
}
}
Expand Down Expand Up @@ -808,7 +808,7 @@ bool HashBuild::finishHashBuild() {
: BaseHashTable::kNoSpillInputStartPartitionBit,
allowParallelJoinBuild ? operatorCtx_->task()->queryCtx()->executor()
: nullptr,
dropDuplicates_,);
dropDuplicates_);
}
stats_.wlock()->addRuntimeStat(
BaseHashTable::kBuildWallNanos,
Expand Down
4 changes: 2 additions & 2 deletions velox/exec/HashTable.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1746,7 +1746,7 @@ void HashTable<ignoreNullKeys>::prepareJoinTable(
// Call analyze to insert all unique values in row container to the
// table hashers' uniqueValues_;
if (!analyze()) {
setHashMode(HashMode::kHash, 0);
setHashMode(HashMode::kHash, 0, spillInputStartPartitionBit);
}
}
otherTables_.reserve(tables.size());
Expand Down Expand Up @@ -1782,7 +1782,7 @@ void HashTable<ignoreNullKeys>::prepareJoinTable(
// Before merging with the current hashers, all values in the row
// containers of other table need to be inserted into uniqueValues_.
if (!other->analyze()) {
other->setHashMode(HashMode::kHash, 0);
other->setHashMode(HashMode::kHash, 0, spillInputStartPartitionBit);
useValueIds = false;
break;
}
Expand Down

0 comments on commit 69a29bb

Please sign in to comment.