Skip to content

Commit

Permalink
Make 'https' the default GCS Scheme (#6361)
Browse files Browse the repository at this point in the history
Summary:
The GCS Hive Connector is currently using insecure connection by default. It should behave like S3 and use secure connections by default. This change makes GCS use https as default scheme.

Fixes #6359

Pull Request resolved: #6361

Reviewed By: xiaoxmeng

Differential Revision: D48859558

Pulled By: kgpai

fbshipit-source-id: 0ee31da85f31e1fd1292dfae43b30f4744a992cf
  • Loading branch information
tigrux authored and facebook-github-bot committed Aug 31, 2023
1 parent 25c7b60 commit 39ec3b0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion velox/connectors/hive/HiveConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ std::string HiveConfig::gcsEndpoint(const Config* config) {

// static
std::string HiveConfig::gcsScheme(const Config* config) {
return config->get<std::string>(kGCSScheme, std::string(""));
return config->get<std::string>(kGCSScheme, std::string("https"));
}

// static
Expand Down

0 comments on commit 39ec3b0

Please sign in to comment.