Support for GHC 9.10 #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
11 tasks
|
@pepeiborra this should be ready to merge. |
|
Can we also add ghc 9.10.1 to CI? or ghc 9.10 support can be broken again without notice in the future. https://github.com/facebookincubator/retrie/blob/main/.github/workflows/test.yml#L12,L16 |
|
Ping @wz1000 |
|
I am looking at the test failures. |
- Remove earlier comments from previous upgrade - Add CPP to silence a bunch of warnings
By adjusting the paren addition code, 9.10 exactprint uses spans for delta calcs, we can keep them
Down to 19 failures
Drops to 17/86
whitespace, commenting debug bits
now 13/86
12/86
11/86
When we finalise the templates, do makeDeltaAst for all variants. This fixes Types2 and Parens tests, but breaks Readme1 Types3 Types4
We need the patterns to be located, to not replace the original when matching. Down to 6/86
Brings it to 5/86 remaining failures
This is used to filter out potential matches in the file the query originates in. But often we have had to re-arrange it with deltas at the point of matching, so can no longer easily extract it from the pattern to be matched. Instead we store it explicitly when making a Query
Still 5/86 failures, but fewer failing instances in PatternSyn2
This sorts out surrounding spacing. Down to 4/86
Recursion /is/ needed, because we are moving things around at this level, the child nodes may need re-arranging as a result Still 3/86, but they all relate to comments. I think.
Which has made most exactprint transform functions pure, rather than in TransFormT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a ghc-exactprint release, currently builds against https://github.com/alanz/ghc-exactprint/tree/ghc-9.10