speed up fizz github CI by using the system deps #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arvinzojaji
approved these changes
Jul 21, 2023
ahornby
force-pushed
the
pr95
branch
2 times, most recently
from
38810cb
to
6e82f0e
Compare
Summary: In previous changed noticed the CI was quite slow as it was building things like boost every time. Regenerated it with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --src-dir=. --output-dir=.github/workflows fizz ``` Test Plan: CI
|
cc @mingtaoy looks like this speeds up the github CI quite a lot |
|
@mingtaoy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Mar 15, 2024
Summary: speed up fizz github CI by using the system deps so that boost & cmake etc aren't rebuilt each time In previous changed noticed the CI was quite slow as it was building things like boost every time. Regenerated it with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages generate-github-actions --src-dir=. --output-dir=.github/workflows fizz ``` X-link: facebookincubator/fizz#95 Reviewed By: bigfootjon Differential Revision: D54950338 Pulled By: mingtaoy fbshipit-source-id: f14f90c2acca6bab7a8353836a6e492f1b14dc55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speed up fizz github CI by using the system deps so that boost & cmake etc aren't rebuilt each time
Summary:
In previous changed noticed the CI was quite slow as it was building things like boost every time. Regenerated it with:
Test Plan:
CI