Skip to content

Commit

Permalink
Remove C++17 compilation error in fizz
Browse files Browse the repository at this point in the history
Summary: C++17 deprecates declaration of constexpr static members, but seems it was not forced until Xcode 15.

Reviewed By: bricehalder

Differential Revision: D48610644

fbshipit-source-id: 7db31b8e788740b0a1366be8e40e874294ff4c2e
  • Loading branch information
vitalii-topoliuk authored and facebook-github-bot committed Aug 24, 2023
1 parent 0f4045e commit 9aff436
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions fizz/server/TicketCodec-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,12 @@
namespace fizz {
namespace server {

// out-of-line definition of constexpr static data member is redundant in C++17
// and is deprecated
#if __cplusplus < 201703L
template <CertificateStorage Storage>
constexpr folly::StringPiece TicketCodec<Storage>::Label;
#endif // __cplusplus < 201703L

template <CertificateStorage Storage>
Buf TicketCodec<Storage>::encode(ResumptionState resState) {
Expand Down

0 comments on commit 9aff436

Please sign in to comment.