-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Enhance extractFiltersFromRemainingFilter to support an OR #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mbasmanova
wants to merge
1
commit into
facebookincubator:main
Choose a base branch
from
mbasmanova:export-D87378318
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87378318. |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/verax
that referenced
this pull request
Nov 19, 2025
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
618aea2 to
2d77ba3
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/verax
that referenced
this pull request
Nov 19, 2025
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
2d77ba3 to
1c862e3
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/verax
that referenced
this pull request
Nov 19, 2025
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
1c862e3 to
3b018ff
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 19, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 20, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
mbasmanova
added a commit
to mbasmanova/verax
that referenced
this pull request
Nov 20, 2025
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
3b018ff to
b7cfa29
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 21, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
b7cfa29 to
94ad1ed
Compare
mbasmanova
added a commit
to mbasmanova/verax
that referenced
this pull request
Nov 21, 2025
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
…ebookincubator#641) Summary: X-link: facebookincubator/velox#15565 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
94ad1ed to
346e1eb
Compare
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Nov 26, 2025
…ebookincubator#15565) Summary: X-link: facebookincubator/axiom#641 Add support for converting "f(a) OR g(a)" to subfield filter. For example, - a > 0 OR a < 10 becomes BigintRange(1, 9) Differential Revision: D87378318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/velox#15565
Add support for converting "f(a) OR g(a)" to subfield filter.
For example,
Differential Revision: D87378318