Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for crash in -[SRWebSocket stream:handleEvent:] cause of released SRWebSocket #533

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix for crash in -[SRWebSocket stream:handleEvent:] cause of released SRWebSocket #533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8abd4ed
Update SRWebSocket.m
sivanmoshe Aug 3, 2017
d044113
Update SRWebSocket.m
sivanmoshe Aug 3, 2017
348dae3
Update SRWebSocket.m
sivanmoshe Aug 3, 2017
94b3e19
Update SRWebSocket.m
sivanmoshe Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update SRWebSocket.m
  • Loading branch information
@sivanmoshe
sivanmoshe authored Aug 3, 2017
commit 94b3e1923095a9b0739da9d21cf8c834e09bda3c
10 changes: 5 additions & 5 deletions SocketRocket/SRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,12 +1116,12 @@ - (void)_scheduleCleanup
}

_cleanupScheduled = YES;

// Cleanup NSStream delegate's in the same RunLoop used by the streams themselves:
// This way we'll prevent race conditions between handleEvent and SRWebsocket's dealloc
NSTimer *timer = [NSTimer timerWithTimeInterval:(0.0f) target:self selector:@selector(_cleanupSelfReference:) userInfo:nil repeats:NO];
[[NSRunLoop SR_networkRunLoop] addTimer:timer forMode:NSDefaultRunLoopMode];
}

// Cleanup NSStream delegate's in the same RunLoop used by the streams themselves:
// This way we'll prevent race conditions between handleEvent and SRWebsocket's dealloc
NSTimer *timer = [NSTimer timerWithTimeInterval:(0.0f) target:self selector:@selector(_cleanupSelfReference:) userInfo:nil repeats:NO];
[[NSRunLoop SR_networkRunLoop] addTimer:timer forMode:NSDefaultRunLoopMode];
}

- (void)removeAllFromRunLoops {
Expand Down