base.py: code quality improvements #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff removes internal references to wikis, documentation, code, etc from utils.py and its tests. Differential Revision: D90120757
Summary: Code quality improvements for base.py following Google Python style guide. **Docstring improvements:** - Standardized docstring format with summary on the same line as opening quotes - Added consistent punctuation to all parameter descriptions (ending with periods) - Fixed docstring indentation to use 4-space hanging indent per Google style - Added missing `:param kwargs:` and `:return:` documentation to `fit_transform` method - Added class-level docstring to `BaseCalibrator` - Wrapped long docstring lines to stay within 80 character limit Differential Revision: D90168232
TaXxER
requested review from
Lorenzo-Perini,
danielha1 and
flinder
as code owners
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 2a628f0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Code quality improvements for base.py following Google Python style guide.
Docstring improvements:
:param kwargs:and:return:documentation tofit_transformmethodBaseCalibratorDifferential Revision: D90168232