fix upper case use of NUM_ROUNDS, PATIENCE in plotting.py #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
flinder
force-pushed
the
export-D90111397
branch
5 times, most recently
from
1fc9b03 to
1feb57e
Compare
Summary: This slipped our tests on Github because we don't have unittests for `plot_learning_curve`. Adding some basic tests here to close the coverage gap. Reviewed By: TaXxER, Lorenzo-Perini Differential Revision: D90111397
flinder
force-pushed
the
export-D90111397
branch
from
1feb57e to
ddc1363
Compare
|
This pull request has been merged in d4527c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This slipped our tests on Github because we don't have unittests for
plot_learning_curve. Adding some basic tests here to close the coverage gap.Reviewed By: TaXxER, Lorenzo-Perini
Differential Revision: D90111397