Rename MCBoost -> MCGrad 1/n - methods.py #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
flinder
force-pushed
the
export-D89670100
branch
14 times, most recently
from
954da48 to
6b4e8f1
Compare
Summary: This slipped our tests on Github because we don't have unittests for `plot_learning_curve`. Adding some basic tests here to close the coverage gap. Reviewed By: TaXxER, Lorenzo-Perini Differential Revision: D90111397
Summary: Renamed MCBoost -> MCGrad for the implementation to be open sourced. **Core Changes (methods.py):** - Renamed classes: `MCBoost` → `MCGrad`, `RegressionMCBoost` → `RegressionMCGrad` - Renamed base class: `BaseMCBoost` → `BaseMCGrad` - Renamed data class: `MCBoostProcessedData` → `MCGradProcessedData` - Created backward-compatible subclasses `MCBoost` and `RegressionMCBoost` (inheriting from MCGrad) for internal use - Changed `_check_predictions` and `_check_labels` from `staticmethod` to instance methods to support dynamic class names via `self.__class__.__name__` - Updated all docstrings, log messages, and error messages to use new class names. Where possible I used the dynamic name. **Where this wasn't possible (docstrings) I default to "MCGrad", favoring consistency in the open source version** **Plotting Changes (plotting.py):** - Renamed `plot_learning_curve` parameter: `mcboost_model` → `mcgrad_model` - Updated all internal variable references from `mcboost_model` to `mcgrad_model` **Tuning Changes (tuning.py):** - Renamed function: `tune_mcboost_params` → `tune_mcgrad_params` - Added backward-compatible alias: `tune_mcboost_params = tune_mcgrad_params` **Transformer Changes (mcboost_transformer.py):** - Updated abstract property type hints: `type[methods.BaseMCBoost]` → `type[methods.BaseMCGrad]` - Updated related comments referencing the abstract return type **Test Changes (test_methods.py, test_metrics.py):** - Updated all test parametrization to use `MCGrad`/`RegressionMCGrad` - Renamed test functions from `test_mcboost_*` → `test_mcgrad_*` - Updated comments referencing MCBoost to MCGrad - Updated isinstance checks to use `BaseMCGrad` Reviewed By: TaXxER Differential Revision: D89670100
flinder
force-pushed
the
export-D89670100
branch
from
6b4e8f1 to
17975a8
Compare
|
This pull request has been merged in 58cc162. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Renamed MCBoost -> MCGrad for the implementation to be open sourced
Created two subclasses for MCBoost and RegressionMCBoost for backward compatibility.
Differential Revision: D89670100