methods.py code quality review - Rename upper case class attributes -> lower case class attributes (start with MONTONE_T) #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
flinder
force-pushed
the
export-D89061588
branch
from
1140919 to
0aad619
Compare
…> lower case class attributes (start with MONTONE_T) (#54) Summary: Dynamically set class attributes should be lower case according to PEP8 / Google style guide. I introduce a backward compatibility module `_compat.py` (python convention) to avoid cluttering the main class. How it works: It implements a Mixinclass which adds deprecated alias descriptors to the class. This allows retaining the old attribute name and produce a deprecation warning whenever it is set or accessed. Since we don't have open source users yet, backward compatibility is not a concern there, therefore I `oss-disable` the mixin. Reviewed By: Lorenzo-Perini Differential Revision: D89061588
flinder
force-pushed
the
export-D89061588
branch
from
0aad619 to
a0ee33b
Compare
|
This pull request has been merged in f8b525b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Dynamically set class attributes should be lower case according to PEP8 / Google style guide.
I introduce a backward compatibility module
_compat.py(python convention) to avoid cluttering the main class.How it works: It implements a Mixinclass which adds deprecated alias descriptors to the class. This allows retaining the old attribute name and produce a deprecation warning whenever it is set or accessed.
Since we don't have open source users yet, backward compatibility is not a concern there, therefore I
oss-disablethe mixin.Differential Revision: D89061588