Fix setuptools_scm root configuration for GitHub releases #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Change setuptools_scm root from '..' to '.' so that it correctly finds the git repository when building from the GitHub repo root. The previous setting caused version detection to fail, resulting in the fallback version 0.0.0 being used instead of the git tag version. Reviewed By: flinder Differential Revision: D91913094
TaXxER
requested review from
Lorenzo-Perini,
danielha1 and
flinder
as code owners
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in c8f1016. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Change setuptools_scm root from '..' to '.' so that it correctly finds
the git repository when building from the GitHub repo root. The previous
setting caused version detection to fail, resulting in the fallback
version 0.0.0 being used instead of the git tag version.
Reviewed By: flinder
Differential Revision: D91913094