-
Notifications
You must be signed in to change notification settings - Fork 4
Log score after each tuning trial #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flinder
wants to merge
4
commits into
facebookincubator:main
Choose a base branch
from
flinder:export-D91884586
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92772f0 to
83d7951
Compare
flinder
added a commit
to flinder/MCGrad-1
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookincubator#199 Log the completion score after each trial iteration, not just the initial trial. This provides better visibility into the tuning progress and helps users monitor how the hyperparameter search is progressing. Differential Revision: D91884586
83d7951 to
98724fd
Compare
flinder
added a commit
to flinder/MCGrad-1
that referenced
this pull request
Jan 30, 2026
Summary: Pull Request resolved: facebookincubator#199 Log the completion score after each trial iteration, not just the initial trial. This provides better visibility into the tuning progress and helps users monitor how the hyperparameter search is progressing. Differential Revision: D91884586
0308feb to
dc2db63
Compare
Summary: Add a `use_model_predictions` parameter to `tune_mcgrad_params` with `False` as the default. When False, returns the actual observed best trial parameters. When True, uses the Bayesian surrogate model's predicted best parameters. The default is False because with few tuning trials, the surrogate model may not be well-calibrated and could return suboptimal parameters that don't match the actual best observed trial. Users who want the model-predicted best can set this to True. Differential Revision: D91889101
Summary: Use log_loss from sklearn instead of normalized_entropy as the tuning objective. This matches MCGrad's early stopping metric, providing directly comparable outputs between tuning and model training. The log_loss metric is a standard choice for probabilistic predictions and is widely understood. Reviewed By: Lorenzo-Perini Differential Revision: D91884587
Summary: Suppress _utils.logger alongside methods.logger during tuning trials to prevent "Unshrink is not close to 1" warnings from appearing. These warnings are expected during hyperparameter exploration but can be noisy for users running tuning jobs. Reviewed By: Lorenzo-Perini Differential Revision: D91884585
Summary: Log the completion score after each trial iteration, not just the initial trial. This provides better visibility into the tuning progress and helps users monitor how the hyperparameter search is progressing. Reviewed By: Lorenzo-Perini Differential Revision: D91884586
dc2db63 to
2b00f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Log the completion score after each trial iteration, not just the initial trial.
This provides better visibility into the tuning progress and helps users monitor
how the hyperparameter search is progressing.
Differential Revision: D91884586