Make internal class attributes private in MCGrad classes #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flinder
requested review from
Lorenzo-Perini,
TaXxER and
danielha1
as code owners
meta-cla
bot
added
the
CLA Signed
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage ? 94.92%
=======================================
Files ? 9
Lines ? 1753
Branches ? 0
=======================================
Hits ? 1664
Misses ? 89
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: The API documentation was exposing internal implementation details (DEFAULT_HYPERPARAMS, UNSHRINK_LOGIT_EPSILON) that should not be part of the public API. Making these attributes private (prefixed with `_`) hides them from the generated Sphinx documentation. For backward compatibility, deprecated aliases are provided via the existing `DeprecatedAttributesMixin` on MCBoost/RegressionMCBoost. These emit `DeprecationWarning` when accessed. Internal users using MCBoost can continue using the old names but will see deprecation warnings encouraging migration to the new private names. Differential Revision: D91786473
flinder
force-pushed
the
export-D91786473
branch
from
047a0bc to
7bed941
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The API documentation was exposing internal implementation details (DEFAULT_HYPERPARAMS, UNSHRINK_LOGIT_EPSILON) that should not be part of the public API. Making these attributes private (prefixed with
_) hides them from the generated Sphinx documentation.Differential Revision: D91786473