Skip to content

Commit

Permalink
Update the built_marker hashing logic only for current project (#3934)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebookincubator/velox#3934

Reviewed By: shri-khare

Differential Revision: D42996394

fbshipit-source-id: e4fe54ba6e7f51b4fc640bf80bbb18b257903b1c
  • Loading branch information
somasun authored and facebook-github-bot committed Feb 3, 2023
1 parent 78ea444 commit 45c11c1
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions build/fbcode_builder/getdeps.py
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,12 @@ def run_project_cmd(self, args, loader, manifest):
)
builder.build(install_dirs, reconfigure=reconfigure)

# Update built_marker only if user hasn't built a specific target
if m == manifest and args.cmake_target == "install":
# If we are building the project (not depdendency) and a specific
# cmake_target (not 'install') has been requested, then we don't
# set the built_marker. This allows subsequent runs of getdeps.py
# for the project to run with different cmake_targets to trigger
# cmake
if not (m == manifest and args.cmake_target != "install"):
with open(built_marker, "w") as f:
f.write(project_hash)

Expand Down

0 comments on commit 45c11c1

Please sign in to comment.